Skip to content

[FSSDK-11175] Update: Implement Decision Service methods to handle CMAB #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

FarhanAnjum-opti
Copy link
Contributor

Summary

Decision Service methods to handle CMAB

Test plan

Added unit tests

Issues

FSSDK-11175

@Mat001 Mat001 requested review from raju-opti and Mat001 June 16, 2025 18:43
…essages and add a test for handling 500 errors
…lt and updating get_variation return type to include detailed error information
-test cases changed to handle return type dicts of DecisionResult and VariationResult
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Have Raju review too.

reasons = decision_list[i]['reasons']
# Can catch errors now. Not used as decision logic implicitly handles error decision.
# Will be required for impression events
# error = decision_list[i]['error']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants